-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VitessAware system variables of type boolean return NULL when MySQL is not involved #7353
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
The new test case: vitess/go/vt/vtgate/executor_select_test.go Line 371 in 9e2c673
|
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
To reproduce the issue we can use the
A fix has been introduced in 34ffa84 allowing the EvalEngine to handle 32-bit variables. It seems that 64-bit variables are used by queries that needs to communicate with MySQL, and 32-bit are used for VTGate-only query. Unit tests have been modified accordingly. The behavior now is as followed:
Ran on:
|
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Up until now, boolean bind variables were typed For instance, the following query returns a type
Whereas the following query returns a type
To suppress this problem, @systay and I decided upon using |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Description
This PR fixes #7301. As detailed in the issue, selecting a
VitessAware
system variable without involving MySQL/Vttablets might return a nil result.Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: